-
Notifications
You must be signed in to change notification settings - Fork 15
Refactored as a directive #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package update, added Comments, missing ;
# Conflicts: # README.md
# Conflicts: # README.md
Cool, I will have a look tomorrow! |
So, my problem is still that while yes, it is now a directive, the application that housed the functionality is gone. The application was first and foremost actually sort of usable, and second, it made it easy to play around and test the functionality. It is likely that we should more clearly split those two in some future, but at this stage at least I want the application to remain somewhere in the repository, perhaps as an example or utility, but one that uses the directive. Because as it is now, the sfbSchema isn't really separate anyway, it is in the app structure. I would propose a build/lib for the directive and its dependencies, and a build/example or build/utility for the. @rowino : However, you were considering some rewriting, was that WRT the app or the functionality in the directive, the actual builder? |
Sure, that sounds good. |
@ThomasPe, first thanks for the input. Nice having others contribute into it. As for the directive, I had mentioned to @nicklasb earlier that I was thinking of spliting the generator into a plain js library then create a angular-directive separate. Reason being to allow reuse with other frameworks. We'll then have a site somewhere for people to use it for quick forms while for in-app use one can use the directive or their framework of choice. Does this shade some light? |
@rowino, @ThomasPe : Basically that would mean that this repo would become home to the pure ES6 library, and then we would create another for the angular/react/whatever directives/implementations. The plan for the json-schema-core has been to later call it json-schema-core-es6, as there are other core implementations on the horizon, like json-schema-core-java, json-schema-core-php and whatnot. Should we therefore rename this repo json-schema-form-builder-es6? And then the app, wherever that ends up will be what it wants to be? |
Either way, that means that we just merge this and works from there? |
Done. |
Finally, I got around to dealing with the rebase. Hopefully I've done it right this time - the GitHub Desktop app is really helpful, though.
I have now refactored the builder controller so it can be used as a directive.
I feel it's now at a point where we can start working on it "issues-based" to weed out bugs and add missing features.